Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Cardano stake distribution commands in mithril-client CLI #1883

Merged
merged 9 commits into from
Aug 12, 2024
Merged

Implement Cardano stake distribution commands in mithril-client CLI #1883

merged 9 commits into from
Aug 12, 2024

Conversation

dlachaume
Copy link
Collaborator

@dlachaume dlachaume commented Aug 8, 2024 •
edited
Loading

Content

This PR adds support for new commands in the mithril-client CLI for CardanoStakeDistribution.
These commands are currently unstable and must be used with the --unstable option.

  • list: ./mithril-client --unstable cardano-stake-distribution list

  • download: ./mithril-client --unstable cardano-stake-distribution download $UNIQUE_IDENTIFIER
    The $UNIQUE_IDENTIFIER can be either the hash or the epoch of the CardanoStakeDistribution.
    The identifier latest is also supported.

An alias csd has been created for cardano-stake-distribution.

Pre-submit checklist

  • Branch
    • Tests are provided (if possible)
    • Crates versions are updated (if relevant)
    • CHANGELOG file is updated (if relevant)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
  • PR
    • No clippy warnings in the CI
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested
  • Documentation
    • Update README file (if relevant)
    • Update documentation website (if relevant)
    • Add dev blog post (if relevant)

Issue(s)

Closes #1880

@dlachaume dlachaume self-assigned this Aug 8, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 8, 2024 •
edited
Loading

Test Results

    4 files  ± 0     53 suites  ±0   9m 14s ⏱️ ±0s
1 229 tests + 4  1 229 ✅ + 4  0 💤 ±0  0 ❌ ±0 
1 437 runs  +16  1 437 ✅ +16  0 💤 ±0  0 ❌ ±0 

Results for commit bf5135f. ± Comparison against base commit c9a1e5b.

♻️ This comment has been updated with latest results.

@dlachaume dlachaume temporarily deployed to testing-preview August 8, 2024 09:42 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 8, 2024 09:42 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1880/implement-cardano-stake-distribution-in-client-cli branch from 44dc188 to fe75b1a Compare August 8, 2024 12:30
@dlachaume dlachaume temporarily deployed to testing-preview August 8, 2024 12:40 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 8, 2024 12:40 — with GitHub Actions Inactive
@dlachaume
feat: create unstable cardano-stake-distribution command
27cd88b 
- add 'csd' alias for 'cardano-stake-distribution'
- implement 'cardano-stake-distribution list' command
- add common function to create the 'unstable' flag missing error message
@dlachaume dlachaume force-pushed the dlachaume/1880/implement-cardano-stake-distribution-in-client-cli branch from fe75b1a to f7a2d3f Compare August 8, 2024 13:58
@dlachaume dlachaume temporarily deployed to testing-preview August 8, 2024 14:09 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 8, 2024 14:09 — with GitHub Actions Inactive
@dlachaume dlachaume force-pushed the dlachaume/1880/implement-cardano-stake-distribution-in-client-cli branch from f7a2d3f to 946a0f6 Compare August 8, 2024 14:11
@dlachaume dlachaume marked this pull request as ready for review August 8, 2024 14:11
@dlachaume dlachaume temporarily deployed to testing-preview August 8, 2024 14:26 — with GitHub Actions Inactive
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 8, 2024 14:26 — with GitHub Actions Inactive
@dlachaume dlachaume requested a review from Alenar August 9, 2024 16:23
Alenar
Alenar approved these changes Aug 12, 2024
View reviewed changes
Copy link
Collaborator

@Alenar Alenar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 💪, just two minor suggestions.

mithril-client-cli/src/commands/cardano_stake_distribution/download.rs Show resolved Hide resolved
mithril-test-lab/mithril-end-to-end/src/assertions/check.rs Outdated Show resolved Hide resolved
@dlachaume dlachaume force-pushed the dlachaume/1880/implement-cardano-stake-distribution-in-client-cli branch from 946a0f6 to bf5135f Compare August 12, 2024 14:09
@dlachaume dlachaume temporarily deployed to testing-sanchonet August 12, 2024 14:25 — with GitHub Actions Inactive
@dlachaume dlachaume merged commit dea7b54 into main Aug 12, 2024
40 of 41 checks passed
@dlachaume dlachaume deleted the dlachaume/1880/implement-cardano-stake-distribution-in-client-cli branch August 12, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alenar Alenar Alenar approved these changes

Assignees

@dlachaume dlachaume

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement Cardano Stake Distribution in client CLI
2 participants
@dlachaume @Alenar